Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On enum name sanitize, convert colon to underscore #20391

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

AntoineDuComptoirDesPharmacies
Copy link
Contributor

@AntoineDuComptoirDesPharmacies AntoineDuComptoirDesPharmacies commented Dec 31, 2024

Fixes #20390

Some new tests have been added to verify that ':' is converted to '_'.

Some codegen (JavaModel and CrystalClient) have been modified to manage this new 'colon' sanitize.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Manage colon converting to underscore on sanitize
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for typescript

@macjohnny
Copy link
Member

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) for java

@wing328 wing328 added this to the 7.11.0 milestone Jan 6, 2025
@wing328 wing328 merged commit 4b5dfc4 into OpenAPITools:master Jan 6, 2025
15 checks passed
@wing328
Copy link
Member

wing328 commented Jan 6, 2025

For those using the Java generators impacted by this, please use the property name mapping option (nameMappings) for fallback:

https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping

@wing328 wing328 changed the title #20390 : On enum name sanitize, convert colon to underscore On enum name sanitize, convert colon to underscore Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [typescript-fetch] Incorrect uppercase enum name when having colon
3 participants